feat: support validation for method fields in *Request
#81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #75
The Problem
As identified in issue #75, the individual
*Requeststructs (e.g.,PingRequest,ListResourcesRequest) do not currently validate that theirmethodfield matches the constant value defined in the JSON schema. This creates ambiguity. For example, a JSON payload like:{ "method": "wrong/method", "params": { /* ... valid params for ListResourcesRequest ... */ } }could be incorrectly deserialized as a
ListResourcesRequest. The deserialization process should fail fast if themethodname is incorrect for the target struct.The Solution
This pull request proposes a robust pattern to validate the
methodfield by leveraging Serde's#[serde(deserialize_with = "...")]:Note for Maintainers